ci: fail when the vendored core/ snapshots drift from upstream - #63
Open
srpatcha wants to merge 1 commit into
Open
ci: fail when the vendored core/ snapshots drift from upstream#63srpatcha wants to merge 1 commit into
srpatcha wants to merge 1 commit into
Conversation
core/eos/ and core/eboot/ are copies of two other repositories in this
organisation, not original source. Nothing keeps them in step, so fixes
merged upstream never arrive here and nothing reports the gap.
Measured against origin/master of both repositories on 2026-08-28:
core/eos 350 files copied from eos 44 already drifted
core/eboot 167 files copied from eBoot 46 already drifted
Ninety files. Any security fix landed in eos or eBoot is absent from the
copy here, silently, and the 21 pull requests currently open against eos
will each widen the gap when they merge.
This adds:
core/UPSTREAM.yaml the pinned upstream revisions
scripts/check_vendor_drift.py fetches each pin and compares
.github/workflows/... runs it on PRs touching core/, and weekly
The existing 90 files are grandfathered through baseline_drift so this
can merge without blocking work in flight. New drift fails. Reducing the
drift lowers the baseline; raising the baseline to make CI pass defeats
the file and the script says so.
This is a stopgap, not the fix. ADR-019 in the eos repository records the
decision to replace both snapshots with real pinned dependencies, and to
reconcile the 90 drifted files one at a time — each is either a change
that belongs upstream, or one that should be reverted.
Verified: the checker reproduces 44 and 46 independently of the git
blob-hash comparison above, and exits 0 with the baselines set and 1 when
either is lowered.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core/eos/andcore/eboot/are copies of two other repositories in this organisation, not original source. Nothing keeps them in step, so fixes merged upstream never arrive here and nothing reports the gap.Measured against
origin/masterof both repositories on 2026-08-28, by comparing git blob hashes:core/eos← eoscore/eboot← eBootNinety files. Any security fix landed in
eosoreBootis absent from the copy here, silently — and the 21 pull requests currently open againsteoswill each widen the gap when they merge.What lands
core/UPSTREAM.yamlscripts/check_vendor_drift.py.github/workflows/vendor-drift.ymlcore/, and weeklyThe existing 90 files are grandfathered through
baseline_driftso this can merge without blocking work in flight. New drift fails. Reducing drift lowers the baseline; raising the baseline to make CI pass defeats the file, and the script says so in its failure message.This is a stopgap, not the fix
ADR-019 (embeddedos-org/eos#69) records the decision to replace both snapshots with real pinned dependencies, and to reconcile the 90 drifted files one at a time — each is either a change that belongs upstream, or one that should be reverted. Visible drift is not a fix; invisible drift is the actual danger.
Verification
The checker reproduces 44 and 46 independently of the git blob-hash comparison above. It exits 0 with the baselines set, and 1 when either is lowered. Workflow YAML parses; Python compiles clean.