Standardized code - #1229
Merged
Merged
Standardized code#1229
Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Created by ember-asset-size-action |
ijlee2
commented
Sep 9, 2026
Comment on lines
-12
to
-14
| get id(): string { | ||
| return guidFor(this); | ||
| } |
Member
Author
There was a problem hiding this comment.
We'd use uniqueId instead of guidFor in a modern Ember project. However, the former is reported to not work in FastBoot.
Since the component was used only once, there's no need to accept the argument @color and generate a random ID. I removed them for simplicity.
ijlee2
marked this pull request as ready for review
September 9, 2026 10:07
jaredgalanis
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
A clean-up PR that follows up on #1227.
I enabled the lint rules
ember/no-unused-servicesandember/template-sort-invocationsto help remove unused code and minimize variations in code. The former isn't safe to use in JavaScript files, so I only enabled it for*.{gts,ts}files.