Fix(admin): Localize MediaPickerModal#1465
Merged
ascorbic merged 2 commits intoJun 15, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 4ba0e2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Contributor
There was a problem hiding this comment.
This PR correctly localizes the two remaining hardcoded "Library" strings in MediaPickerModal.tsx by wrapping them with Lingui's t`Library` macro. The approach is sound: it's a focused follow-up that brings MediaPickerModal in line with the already-localized MediaLibrary component (which uses the identical pattern for its built-in provider label).
I verified:
- Both changed
useMemodependency arrays were properly updated to includet, so locale changes invalidate the memoized labels. - No other untranslated user-facing strings remain in
MediaPickerModal.tsx. - The
changesetfollows the required format and accurately describes the user-facing fix. - The diff is minimal and scoped exactly to the stated purpose.
No issues found — clean localization fix.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a follow-up on: #1244
It wraps the
MediaPickerModalbuilt-in Library provider label with Lingui so they follow the selected admin locale.For now, the
MediaPickerModalis fully covered for translations. Translators can pickup the changes of theirmessages.poto finish this story.Closes #
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output