Fix(admin): Localize plugin API errors - #1469
Merged
ascorbic merged 2 commits intoJun 15, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: e50dae5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Contributor
There was a problem hiding this comment.
This PR is a clean, scoped follow-up that localizes the remaining hard-coded English fallback error messages in packages/admin/src/lib/api/plugins.ts. The approach is sound and consistent with the existing codebase: fetchManifest in the same directory’s client.ts and several marketplace endpoints already use the i18n._(msg\…`)` pattern for runtime translation outside React components.
I checked:
- Approach & scope: Narrow and correct. Only
plugins.tsis touched, matching the stated goal of localizing plugin API errors. - Localization pattern:
i18n._(msg\…`)with interpolation (pluginId) is valid Lingui macro syntax and matches usage across the admin API layer. Thei18nsingleton is loaded and activated inApp.tsx` before any component-driven API calls occur. - Logic & regressions: No behavior changes other than string source. No missing awaits, no type issues, no altered control flow.
- AGENTS.md conventions: Changeset is present, properly formatted, and user-facing (present-tense verb + observable effect). No
.pofiles are modified, following the extraction-on-merge rule. No tests are required for this pure string-localization change. - Siblings/cross-cutting: Other API files still contain unlocalized fallback strings, but those are outside this PR’s scope and there is no requirement to bulk-fix them.
No issues found.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a follow-up on: #1244
It localizes the plugin API fallback error messages to get them covered by Lingui.
Closes #
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output