Skip to content

Fix compiler error when exporting integers while emitting tsd#27412

Open
jeremy-code wants to merge 1 commit into
emscripten-core:mainfrom
jeremy-code:26589
Open

Fix compiler error when exporting integers while emitting tsd#27412
jeremy-code wants to merge 1 commit into
emscripten-core:mainfrom
jeremy-code:26589

Conversation

@jeremy-code

Copy link
Copy Markdown

Sorry, this is a duplicate of #26590. I had deleted the branch last week since I thought it had already been merged, so I am reopening it.

- Fixes emscripten-core#26589
- Replaces concatenation (which can error when snippet is an int) with f-string
- Update test_other.py to include POINTER_SIZE
@sbc100

sbc100 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

It looks like you need to run ./test/runner other.test_emit_tsd_jspi --rebaseline

@jeremy-code

Copy link
Copy Markdown
Author

I just did:

(.venv)  ✘ jeremy@MacBookAir  ~github/emscripten   26589  ./test/runner.py other.test_emit_tsd_jspi --rebaseline
config:WARNING: Found list-style config entry (['/Users/jeremy/.nodenv/shims/node']).  Please use a single string with spaces between args.
config:WARNING: Found list-style config entry (['/Users/jeremy/.nodenv/shims/node']).  Please use a single string with spaces between args.
Running 1 tests

Didn't seem to produce any artifacts that I could commit, is something wrong?

@sbc100

sbc100 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Somehow test/other/test_emit_tsd_jspi.d.ts should be updated too.

If you run that test without rebaseline argument does it not fail (like its in CI)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emitting TSD errors when exporting POINTER_SIZE

2 participants