Fix compiler error when exporting integers while emitting tsd#27412
Open
jeremy-code wants to merge 1 commit into
Open
Fix compiler error when exporting integers while emitting tsd#27412jeremy-code wants to merge 1 commit into
jeremy-code wants to merge 1 commit into
Conversation
- Fixes emscripten-core#26589 - Replaces concatenation (which can error when snippet is an int) with f-string - Update test_other.py to include POINTER_SIZE
sbc100
approved these changes
Jul 24, 2026
Collaborator
|
It looks like you need to run |
Author
|
I just did: Didn't seem to produce any artifacts that I could commit, is something wrong? |
Collaborator
|
Somehow If you run that test without rebaseline argument does it not fail (like its in CI)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, this is a duplicate of #26590. I had deleted the branch last week since I thought it had already been merged, so I am reopening it.