Refactor src/lib/libopenal.js. NFC - #27425
Open
sbc100 wants to merge 1 commit into
Open
Conversation
kripken
reviewed
Jul 28, 2026
kripken
reviewed
Jul 28, 2026
|
|
||
| for (var i in ctx.sources) { | ||
| AL.scheduleSourceAudio(ctx.sources[i]); | ||
| for (var src of Object.values(ctx.sources)) { |
Member
There was a problem hiding this comment.
The same is true here, I think? Object.values allocates a new output array.
- Use `for .. of` in a few more places. - Remove duplication in setSourceParam(AL_BUFFER)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for .. ofin a few more places.setSourceParam(AL_BUFFER). Theifcondition here had a lot of the same code on each branch.