Skip to content

Add failing test for isMemo bug (#2390)#2408

Open
bdwain wants to merge 1 commit intoenzymejs:masterfrom
bdwain:master
Open

Add failing test for isMemo bug (#2390)#2408
bdwain wants to merge 1 commit intoenzymejs:masterfrom
bdwain:master

Conversation

@bdwain
Copy link
Copy Markdown
Contributor

@bdwain bdwain commented Jun 26, 2020

This is in response to #2390 . By throwing away the type information of the render result, we cause isMemo checks to fail on elements that have gone through the wrapper. Ideally they would pass the isMemo check

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.31%. Comparing base (f046079) to head (42d5f9e).
⚠️ Report is 78 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2408   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          49       49           
  Lines        4204     4207    +3     
  Branches     1130     1130           
=======================================
+ Hits         4049     4052    +3     
  Misses        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ljharb ljharb force-pushed the master branch 3 times, most recently from 43eb75e to 39e6b1f Compare November 3, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant