fix: guard flush() for pre-v0.1.2 ePHPm runtimes#1
Merged
Conversation
SapiKvOps::flush() called ephpm_kv_flush_all() unconditionally. That SAPI function only exists in ePHPm v0.1.2+, so on an older runtime wp_cache_flush() would fatal with 'Call to undefined function' rather than no-op. Guard with function_exists (matching ephpm/predis-connection): flush returns false on older runtimes and entries age out via TTL. Decouples the drop-in from the ePHPm release — it can ship now and flush lights up automatically once v0.1.2 is deployed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SapiKvOps::flush() called
ephpm_kv_flush_all()unconditionally, but that SAPI fn only exists in ePHPm v0.1.2+. On an older runtimewp_cache_flush()would fatal (Call to undefined function) instead of no-op.Guard with
function_exists(matching ephpm/predis-connection): returns false on older runtimes, entries age out via TTL. This decouples the drop-in from the ePHPm release so it can ship now and flush activates automatically once v0.1.2 deploys.Tests: 33/33 green (unit tests use InMemoryKvOps, unaffected).