ci: ensure the auto-created release-please action runs CI
#345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that CI workflows are triggered when the release-please action automatically creates a pull request. By switching from the default GITHUB_TOKEN to WORKFLOW_PUSH_BOT_TOKEN, the automated PRs will now properly trigger CI checks, preventing potential issues from unvalidated releases.
Key changes:
- Added
tokeninput to therelease-please-actionusingWORKFLOW_PUSH_BOT_TOKEN - Removed
contents: writeandpull-requests: writepermissions (provided by the bot token) - Maintained
id-token: writeandmodels: readpermissions for npm provenance and other features
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| release-please: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write |
lumirlumir
added
the
accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
This PR follows up on #330.
In this PR, I've ensured the auto-created
release-pleaseaction triggers CI.Problem
Currently, the auto-created PR from the
release-pleaseaction does not trigger CI, as shown below:For example: eslint/rewrite#336
This can result in CI not running and may lead to issues like eslint/rewrite#308 if the check is missing.
Solution
I've used
secrets.WORKFLOW_PUSH_BOT_TOKENinstead of the defaultsecrets.GITHUB_TOKEN, following the same approach described in #330.Also, the
permissionsforcontentsandpull-requestsis no longer necessary becausesecrets.WORKFLOW_PUSH_BOT_TOKENalready grants the required permissions, so I removed it.FYI: the
tokeninput reference: https://github.com/googleapis/release-please-action?tab=readme-ov-file#action-inputsTest
I've tested it in my forked repository (using
rewriterepository), and it works as expected:lumirlumir/fork-rewrite#9
What changes did you make? (Give an overview)
This PR follows up on #330.
In this PR, I've ensured the auto-created
release-pleaseaction triggers CI.Related Issues
Ref: #330
Is there anything you'd like reviewers to focus on?
N/A