Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Dec 15, 2025

Prerequisites checklist

What is the purpose of this pull request?

This PR follows up on eslint/css#330.

In this PR, I've ensured the auto-created release-please action triggers CI.

Problem

Currently, the auto-created PR from the release-please action does not trigger CI, as shown below:

For example: eslint/rewrite#336

image

This can result in CI not running and may lead to issues like eslint/rewrite#308 if the check is missing.

Solution

I've used secrets.WORKFLOW_PUSH_BOT_TOKEN instead of the default secrets.GITHUB_TOKEN, following the same approach described in eslint/css#330.

Also, the permissions for contents and pull-requests is no longer necessary because secrets.WORKFLOW_PUSH_BOT_TOKEN already grants the required permissions, so I removed it.

FYI: the token input reference: https://github.com/googleapis/release-please-action?tab=readme-ov-file#action-inputs

image

Test

I've tested it in my forked repository (using rewrite repository), and it works as expected:

lumirlumir/fork-rewrite#9

  • Before: CI wasn't running
스크린샷 2025-12-15 191430
  • After: CI is running
스크린샷 2025-12-15 191842

What changes did you make? (Give an overview)

This PR follows up on eslint/css#330.

In this PR, I've ensured the auto-created release-please action triggers CI.

Related Issues

Ref: eslint/css#330

Is there anything you'd like reviewers to focus on?

N/A

@lumirlumir lumirlumir marked this pull request as ready for review December 15, 2025 11:29
@lumirlumir lumirlumir requested a review from a team as a code owner December 15, 2025 11:29
Copilot AI review requested due to automatic review settings December 15, 2025 11:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release-please workflow to ensure that automatically created release PRs trigger CI checks. By switching from the default GITHUB_TOKEN to WORKFLOW_PUSH_BOT_TOKEN, PRs created by the release-please action will now properly trigger CI workflows, preventing releases from being created without proper validation.

Key Changes:

  • Replaced GITHUB_TOKEN with WORKFLOW_PUSH_BOT_TOKEN for the release-please action
  • Removed explicit contents: write and pull-requests: write permissions (redundant with bot token)
  • Maintained id-token: write permission for npm provenance support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants