Open
Conversation
Contributor
|
I have run the CI/CD tests on this PR multiple times, and one time on tests failed that I did not saw before: Could be because of these changes? can you please check it out? |
Contributor
Author
|
Checked it out. Can't see how this is related. The goroutine dump in the CI suggest some problem in the CI runner. Note the IO waits etc. |
martinconic
requested review from
akrem-chabchoub,
gacevicljubisa,
janos and
martinconic
| readyC := make(chan struct{}) | ||
| storer.StartReserveWorker(context.Background(), pullerMock.NewMockRateReporter(0), networkRadiusFunc(1), readyC) | ||
| <-readyC | ||
| time.Sleep(time.Second) |
Contributor
There was a problem hiding this comment.
Will time.Sleep still be flaky?
Not sure whether synctest can help here ?
Contributor
Author
There was a problem hiding this comment.
so far i have tried to reproduce any flakiness of these tests locally and even without synctest it passes without a problem
akrem-chabchoub
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A data race in the reserve worker's startup was created in a way that it may get scheduled after the dependent tests already started. I've added a channel to synchronize this behavior. In
node.goI am not using this synchronization as it appears to affect the node startup time in the integration tests.This fixes the flakes in the TestReserveEvict and the TestReplaceOldIndex tests.