deps: upgrade go-libp2p to v0.47.0 - #148
Open
sukunrt wants to merge 2 commits into
Open
Conversation
libp2p swarm notifiees run synchronously before the connection starts accepting inbound streams. The emission broker's Emit waits for all callbacks, so a slow AfterPeerConnect handler (e.g. the crawler's whole crawl) blocked inbound stream handling on the new connection — remote peers' identify and req/resp streams stalled until the handler finished. Emit events on background goroutines, bounded by a 100-slot semaphore so handler concurrency stays capped and misbehaving handlers surface as backpressure instead of unbounded goroutine growth. Assisted-By: Claude Fable 5
Previously held back (ethpandaops#143) because the version bump reproducibly broke Test_RunKurtosisTests: since v0.42.0 identify's default timeout is 5s, and the crawler's blocking Connected handler stalled inbound streams long enough for identify to time out. Fixed by the previous change, which moved event handlers off the notifiee path. go-libp2p-pubsub stays at v0.15.0: v0.16.0+ adds RawTracer.OnClosedOutboundStream, which prysm v6.1.4 (latest release) does not implement, breaking the build. Assisted-By: Claude Fable 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.