Fix missing stream deadlines in SendRequest - #149
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
SendRequest opened streams with a per-request timeout but never applied it to the underlying read and write operations. A peer that accepted a stream and then stopped responding could park the calling goroutine and its libp2p stream indefinitely, since io.ReadFull and the payload write had no deadline at all. Set write and read deadlines from the existing ReqRespConfig before the write and read phases, matching the pattern already used by every sibling function in this file (ReadRequest, WriteRequest, ReadResponse). Adds a test that reproduces the hang against an unresponsive peer and confirms the request now fails within the configured deadline instead of blocking forever, plus a regression test for the normal success path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SendRequest opened streams with a per-request timeout but never applied it to the underlying read and write operations. A peer that accepted a stream and then stopped responding could park the calling goroutine and its libp2p stream indefinitely, since the write and the response read had no deadline at all.
Sets a write deadline before sending the request and a read deadline before waiting for the response, using the existing ReqRespConfig timeout fields. This matches the pattern already used by every sibling function in the file (ReadRequest, WriteRequest, ReadResponse).
Test plan
go build ./...,go vet ./..., and the full package test suite all pass.