Fix missing write deadline in writeRLPx - #150
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
writeRLPx locked writeMu and wrote to the rlpx connection with no write deadline. A peer that completed the handshake and then stopped reading could stall the write indefinitely while the lock was held, wedging the session and every other sender behind it, since they all serialize on the same mutex. Set a write deadline before the write, mirroring the read deadline already applied each iteration of the session loop. The timeout is a package variable rather than a constant so tests can shrink it instead of waiting out the full duration. Adds a test that drives a real handshake against an unresponsive peer and confirms the write now fails within the deadline instead of blocking forever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeRLPx locked writeMu and wrote to the rlpx connection with no write deadline. A peer that completed the handshake and then stopped reading could stall the write indefinitely while the lock was held, wedging the session and every other sender behind it, since they all serialize on the same mutex.
Sets a write deadline before the write, mirroring the read deadline already applied each iteration of the session loop. The timeout is a package variable rather than a constant so tests can shrink it instead of waiting out the full duration.
Test plan
go build ./...,go vet ./..., and the full package test suite all pass.