fix(parser): support optional chaining on slice expressions#945
Open
eyupcanakman wants to merge 1 commit intoexpr-lang:masterfrom
Open
fix(parser): support optional chaining on slice expressions#945eyupcanakman wants to merge 1 commit intoexpr-lang:masterfrom
eyupcanakman wants to merge 1 commit intoexpr-lang:masterfrom
Conversation
Allow nil?.[from:to] to return nil instead of erroring with "cannot slice unknown". Add Optional field to SliceNode, propagate it through parser, checker, and compiler using the same pattern as MemberNode optional chaining. Fixes expr-lang#822
eyupcanakman
force-pushed
the
fix/optional-chain-slice-822
branch
from
cf006b6 to
d239381
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
foo?.[0:1]panics at runtime whenfoois nil. Optional chaining works for member access (foo?.bar) throughMemberNode.Optional+OpJumpIfNil, butSliceNodehad no equivalent.Added the same
Optional+OpJumpIfNilpattern toSliceNode.Fixes #822