-
-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: redirects changelog page to github releases #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| sitemap: false | ||
| redirect_from: | ||
| - "/changelog/4x.html" | ||
| - "en/changelog/4x.html" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use redirect for all /{lang}/changelog pages. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, and we also need to remove the content, and we should also ignore this file in Crowdin (
Line 4 in 76c37f7
| - /en/blog/**/*.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, applied all the changes
🚦 Lighthouse Results (Mobile & Desktop)
|
| ### 4.20.0 - Release date: 2024-09-10 | ||
| {: id="4.20.0"} | ||
|
|
||
| The 4.20.0 minor release includes bug fixes and some new features, including: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk what others prefer? But I think we should keep this en/changelog. Removing all other languages is OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? I'd rather remove all the content if we're going to redirect it to another page that already contains this info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with removing them
Currently, we manually maintain the changelogs in expressjs.com. This change should make it easier for us to maintain the website.
Slack discussion