[ghstack] remove pats dependency#298
Conversation
| # Name of the upstream remote | ||
| ("remote_name", str), | ||
| # Repository name | ||
| ("repo_name", Optional[str]), |
There was a problem hiding this comment.
Hmm, while I want to accept this PR on principle, this is not so good, it means you can only set one repo name for all ghstack uses everwhere on your machine. Any chance I can convince you to introduce a per repo configuration? :)
There was a problem hiding this comment.
makes sense - will give that a stab!
There was a problem hiding this comment.
thinking that with use of github_path in the ~/.ghstack config, I can add a check where, if $github_path/.ghstack exists, use that for per-repo config, otherwise assume no per-repo config exists. is that what you were thinking?
There was a problem hiding this comment.
There's some precedent for just chucking stuff in .git/config (using the standard git cli for modifying it.) How do you like that?
allow local config to override github graphql requests like so