Add tests for merge rules validation engine#321
Open
seemethere wants to merge 4 commits intogh/seemethere/4/headfrom
Open
Add tests for merge rules validation engine#321seemethere wants to merge 4 commits intogh/seemethere/4/headfrom
seemethere wants to merge 4 commits intogh/seemethere/4/headfrom
Conversation
Collaborator
Author
seemethere
added a commit
that referenced
this pull request
Feb 3, 2026
Adds comprehensive test coverage for the merge rules feature: - test/merge_rules/yaml_parsing.py.test: YAML parsing tests - test/merge_rules/pattern_matching.py.test: fnmatch pattern tests - test/merge_rules/approval_validation.py.test: approver validation tests - test/merge_rules/check_validation.py.test: CI check validation tests - test/merge_rules/ignore_flaky.py.test: ignore_flaky_failures flag tests Adds land command integration tests: - test/land/validate_rules_fail.py.test: validation blocks land - test/land/validate_rules_pass.py.test: validation passes and lands - test/land/dry_run.py.test: dry run mode validates but doesn't land Also adds helper functions to test_prelude.py: - set_pr_files, set_pr_reviews, set_pr_check_runs - Updated gh_land to support validate_rules, dry_run, comment_on_failure flags Co-authored-by: Cursor <cursoragent@cursor.com> ghstack-source-id: 4a5247e ghstack-comment-id: 3838814339 Pull-Request: #321
This was referenced Feb 3, 2026
- Remove unused 'import ghstack.merge_rules' from dry_run.py.test and validate_rules_pass.py.test (F401) - Fix trailing whitespace on blank lines (W293)
- Split list comprehension across lines in test_prelude.py - Sort imports alphabetically in approval_validation.py.test
- Add blank line between stdlib and third-party imports - Sort imports alphabetically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive test coverage for the merge rules feature:
Adds land command integration tests:
Also adds helper functions to test_prelude.py:
Co-authored-by: Cursor cursoragent@cursor.com