Adapt UI for Liquid Glass - #51
WilliamWang1721 wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 193d469a91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| VStack(alignment: .leading, spacing: 4) { | ||
| HStack { | ||
| Text("Height") | ||
| Text("settings.height") |
There was a problem hiding this comment.
Add missing localization entry for height label
The new Text("settings.height") label will render the raw key at runtime because settings.height was not added to either en.lproj/Localizable.strings or zh-Hans.lproj/Localizable.strings in this commit. This creates a visible regression in the Settings UI (Dimensions section) for all locales, so the key should be added to the localization tables (or reverted to a literal) to avoid showing settings.height to users.
Useful? React with 👍 / 👎.
Summary
Validation
masterat2c02f3eee2d8eac238c10a20d3d0e4b021465656(v1.7.1) and the localization fixes in Add English and Simplified Chinese localization #505fed08a7ff51720659d4039183d09a42a32c8d5c: macOS 15 / Xcode 16.2 and macOS 26 / Xcode 26.0, building arm64 and x86_64 without signingglassEffectcalls remain centralized behind compiler and runtime availability guardsgit diff --checkpassThe upstream pull-request workflow is waiting for maintainer approval; the linked fork workflow has completed successfully.