Skip to content

Adapt UI for Liquid Glass - #51

Open
WilliamWang1721 wants to merge 6 commits into
f:masterfrom
WilliamWang1721:codex/fresh-worktree
Open

WilliamWang1721 wants to merge 6 commits into
f:masterfrom
WilliamWang1721:codex/fresh-worktree

Conversation

@WilliamWang1721

@WilliamWang1721 WilliamWang1721 commented May 21, 2026 •

Copy link
Copy Markdown

Summary

  • add a lightweight Liquid Glass compatibility layer for macOS 26
  • keep upstream's macOS 15.0 deployment target with material/NSVisualEffectView fallbacks
  • apply the shared glass styling to the main window, settings sheet, waveform pill, and floating teleprompter surfaces

Validation

  • Synced with upstream master at 2c02f3eee2d8eac238c10a20d3d0e4b021465656 (v1.7.1) and the localization fixes in Add English and Simplified Chinese localization #50
  • macOS checks passed on head 5fed08a7ff51720659d4039183d09a42a32c8d5c: macOS 15 / Xcode 16.2 and macOS 26 / Xcode 26.0, building arm64 and x86_64 without signing
  • Native glassEffect calls remain centralized behind compiler and runtime availability guards
  • Localization parity/coverage, resource lint, embedded web JavaScript syntax, and git diff --check pass

The upstream pull-request workflow is waiting for maintainer approval; the linked fork workflow has completed successfully.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 193d469a91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

VStack(alignment: .leading, spacing: 4) {
HStack {
Text("Height")
Text("settings.height")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add missing localization entry for height label

The new Text("settings.height") label will render the raw key at runtime because settings.height was not added to either en.lproj/Localizable.strings or zh-Hans.lproj/Localizable.strings in this commit. This creates a visible regression in the Settings UI (Dimensions section) for all locales, so the key should be added to the localization tables (or reverted to a literal) to avoid showing settings.height to users.

Useful? React with 👍 / 👎.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants