Prepare semantic tokens to include syntax highlighting#3615
Conversation
Pyrefly's semantic pipeline currently models only identifier-level tokens. Future support for a full semantic stream therefore requires a syntax-token source covering keywords, comments, strings, numbers, and operators. This change introduces a lightweight syntax path derived from Ruff's parse results and configures the LSP encoder to split multiline ranges into line-local tokens. To ensure the new path remains unadvertised, this server capability is gated to clients that already augment syntax tokens. This enables proper representation of triple-quoted strings and preserves current semantic-overlay behavior during the gated rollout.
|
Hi @magic-akari! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Pyrefly's semantic pipeline currently models only identifier-level tokens. Future support for a full semantic stream therefore requires a syntax-token source covering keywords, comments, strings, numbers, and operators.
This change introduces a lightweight syntax path derived from Ruff's parse results and configures the LSP encoder to split multiline ranges into line-local tokens. To ensure the new path remains unadvertised, this server capability is gated to clients that already augment syntax tokens.
This enables proper representation of triple-quoted strings and preserves current semantic-overlay behavior during the gated rollout.
Test Plan
python3 test.py --no-test --no-conformance --no-jsonschemacargo test