Fix tests and reland "[debugger-shell] add debug statements to debugger shell launching path" #54978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jan 2, 2026
…er shell launching path" (facebook#54978) Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Differential Revision: D89765226
vzaidman
force-pushed
the
export-D89765226
branch
2 times, most recently
from
d957fef to
d94452d
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jan 5, 2026
…er shell launching path" (facebook#54978) Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Differential Revision: D89765226
vzaidman
force-pushed
the
export-D89765226
branch
from
d94452d to
3c5082f
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jan 7, 2026
…er shell launching path" (facebook#54978) Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Reviewed By: huntie Differential Revision: D89765226
vzaidman
force-pushed
the
export-D89765226
branch
from
3c5082f to
e82813b
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jan 8, 2026
…er shell launching path" (facebook#54978) Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Differential Revision: D89765226
vzaidman
force-pushed
the
export-D89765226
branch
from
e82813b to
87dd6e7
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jan 12, 2026
…er shell launching path" (facebook#54978) Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Differential Revision: D89765226
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jan 12, 2026
…er shell launching path" (facebook#54978) Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Differential Revision: D89765226
vzaidman
force-pushed
the
export-D89765226
branch
from
87dd6e7 to
4770c81
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jan 12, 2026
…er shell launching path" (facebook#54978) Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Differential Revision: D89765226
vzaidman
force-pushed
the
export-D89765226
branch
from
4770c81 to
9715c8e
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jan 12, 2026
…er shell launching path" (facebook#54978) Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Differential Revision: D89765226
vzaidman
force-pushed
the
export-D89765226
branch
from
9715c8e to
4afaf34
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jan 12, 2026
…er shell launching path" (facebook#54978) Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Differential Revision: D89765226
vzaidman
force-pushed
the
export-D89765226
branch
from
4afaf34 to
8ec34ac
Compare
…er shell launching path" (facebook#54978) Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Differential Revision: D89765226
vzaidman
force-pushed
the
export-D89765226
branch
from
8ec34ac to
7fcf37b
Compare
Collaborator
|
This pull request was successfully merged by @vzaidman in b45c820 When will my fix make it into a release? | How to file a pick request? |
This was referenced Jan 13, 2026
meta-codesync bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
Summary: Use of `debug` was added in #54978 but never declared. This causes `react-native config` to fail in pnpm setups. ## Changelog: [GENERAL] [FIXED] - Fixed missing dependency breaking `react-native config` in pnpm setups Pull Request resolved: #55145 Test Plan: `yarn` in `xplat/js` didn't change any files Reviewed By: cortinico Differential Revision: D90589051 Pulled By: vzaidman fbshipit-source-id: b53a46a9b034d385e64a72f85d29e63da02522d7
react-native-bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
Summary: Use of `debug` was added in #54978 but never declared. This causes `react-native config` to fail in pnpm setups. ## Changelog: [GENERAL] [FIXED] - Fixed missing dependency breaking `react-native config` in pnpm setups Pull Request resolved: #55145 Test Plan: `yarn` in `xplat/js` didn't change any files Reviewed By: cortinico Differential Revision: D90589051 Pulled By: vzaidman fbshipit-source-id: b53a46a9b034d385e64a72f85d29e63da02522d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though.
Changelog: [Internal]
Differential Revision: D89765226