Fix copy-paste error in DevToolsRuntimeSettings #55010
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes a copy-paste error in
DevToolsRuntimeSettings::setReloadAndProfileConfigwhererecordChangeDescriptionswas guarded by the wrong optional field.The correct conditional check is already used in https://github.com/facebook/react-native/blob/main/packages/react-native/React/CoreModules/RCTDevToolsRuntimeSettingsModule.mm#L28
Changelog:
[INTERNAL] [FIXED] Fix incorrect optional field check in DevToolsRuntimeSettings
Test Plan:
Code inspection only – trivial copy-paste fix with no behavior change outside correctly applying
recordChangeDescriptionswhen present.