Skip to content

Ensure that alias root.go files are using argparser.Base #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rcaril merged 1 commit into from
Jan 22, 2026
Merged

Ensure that alias root.go files are using argparser.Base #1629

rcaril merged 1 commit into from
Jan 22, 2026

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Jan 22, 2026 •
edited
Loading

Change summary

This PR fixes alias root commands to use standalone pattern instead of wrapping service commands. The healthcheck and backend alias root files were incorrectly wrapping the service command.
Ref: #1622 & #1621.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

User Impact

None.

@rcaril rcaril added the Skip-Changelog do not add a changelog entry for this change label Jan 22, 2026
@rcaril rcaril changed the title Ensure that alias root.go files are using Ensure that alias root.go files are using argparser.Base Jan 22, 2026
@rcaril rcaril marked this pull request as ready for review January 22, 2026 19:24
@rcaril rcaril requested a review from a team as a code owner January 22, 2026 19:24
@rcaril rcaril requested a review from philippschulte January 22, 2026 19:24
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch

@rcaril rcaril merged commit fbf0bb5 into main Jan 22, 2026
26 of 35 checks passed
@rcaril rcaril deleted the rcaril/update-backend-and-healthchck-root-files branch January 22, 2026 20:22
rcaril added a commit that referenced this pull request Jan 23, 2026
@rcaril
Ensure that alias root.go files are using argparser.Base (#1629)
dd437d3 
Init changes
rcaril added a commit that referenced this pull request Jan 23, 2026
@rcaril
Ensure that alias root.go files are using argparser.Base (#1629)
abd27d3 
Init changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

@philippschulte philippschulte Awaiting requested review from philippschulte philippschulte is a code owner automatically assigned from fastly/developer-tools

Assignees

No one assigned

Labels

Skip-Changelog do not add a changelog entry for this change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rcaril @anthony-gomez-fastly