fix: handle zero sample rate in pprof export - #39
Open
Jvlegod wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jvle <keke.oerv@isrc.iscas.ac.cn>
Jvlegod
force-pushed
the
fix-zero-sample-rate
branch
from
July 24, 2026 06:04
1068571 to
fd4bae0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a panic in pprof export when wall-clock profiling is stopped before the first sample is collected.
In that case,
sampleCountis zero, so the measured sample rate rounds to0. Passing that value intoexportPprofcauses a divide-by-zero panic while calculating the profileperiod.
This patch falls back to the configured sampling rate when the measured rate is less than
1.Reproducer
A short-lived program can trigger this by starting and immediately stopping pprof-format profiling: