Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1352 +/- ##
=======================================
Coverage 80.40% 80.40%
=======================================
Files 65 65
Lines 4608 4608
Branches 775 775
=======================================
Hits 3705 3705
Misses 888 888
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Review CI failure then we can merge this |
Contributor
Author
|
Looks like this was due to a hiccup with the Docker rate limit, unrelated to the Node version change in the PR: https://github.com/finos/git-proxy/actions/runs/21365501191/job/61496029981?pr=1352 |
Contributor
Author
|
Will go ahead and merge this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1334.
What was missing in #1351 is fixing the Node version as shown in the NPM guide sample snippet.
The
rc.4is successfully published on NPM - I added publish on PR for commit 4ebf646 and then removed it.