feat(fcm): Add Support for AndroidConfigV2 - #771
Open
jonathanedey wants to merge 3 commits into
Open
jonathanedey wants to merge 3 commits into
jonathanedey wants to merge 3 commits into
Conversation
jonathanedey
marked this pull request as draft
July 9, 2026 19:33
jonathanedey
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the V2 Android messaging configuration (AndroidConfigV2 and AndroidNotificationV2) to the messaging package, deprecating the older V1 Android configuration types. It includes JSON marshalling/unmarshalling implementations, validation logic, unit tests, and usage snippets. Feedback on the changes suggests resetting the VibrateTimingMillis slice in AndroidNotificationV2.UnmarshalJSON before appending to prevent duplicate values when the receiver struct is reused.
jonathanedey
changed the title
jonathanedey
force-pushed
the
je-fcm-v2
branch
from
September 15, 2026 21:16
a91b61a to
88f80be
Compare
jonathanedey
marked this pull request as ready for review
September 15, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements support for the Android v2 API and It deprecates v1
AndroidConfigstructures and replaces them with the newAndroidConfigV2structures.AndroidConfigV2,AndroidNotificationV2,AndroidRemoteNotification, andAndroidBackgroundSyncMessagetypes.AndroidConfig,AndroidNotification, andAndroidNotificationProxy