fix(fac): Use v1beta endpoint for verifyAppCheckToken - #987
Open
lahirumaramba wants to merge 2 commits into
Open
lahirumaramba wants to merge 2 commits into
lahirumaramba wants to merge 2 commits into
Conversation
Updated _AppCheckService._VERIFY_URL_FORMAT to point to the v1beta endpoint (https://firebaseappcheck.googleapis.com/v1beta/projects/{project_id}:verifyAppCheckToken) for replay protection verification.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the App Check verification URL format from 'v1' to 'v1beta' in firebase_admin/app_check.py and updates the corresponding unit tests in tests/test_app_check.py to reflect this change. There are no review comments, and the changes appear to be correct and complete.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #976
Updated
_AppCheckService._VERIFY_URL_FORMATinfirebase_admin/app_check.pyto use thev1betaendpoint (https://firebaseappcheck.googleapis.com/v1beta/projects/{project_id}:verifyAppCheckToken) when verifying token replay protection (consume=True), asverifyAppCheckTokenis publicly exposed underv1beta.