fix(remoteconfig) Support ABT realtime when variant value matches default value of parameter#10000
fix(remoteconfig) Support ABT realtime when variant value matches default value of parameter#10000athiramanu wants to merge 6 commits into
Conversation
🦋 Changeset detectedLatest commit: c01f02b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for rollout and personalization metadata in Remote Config, updating the API definitions, REST client, and realtime handler to process these new fields. Several critical issues were identified in the realtime update logic: the previous fetch response is retrieved from storage after it has likely been overwritten by the new fetch, and the comparison logic for experiments and rollouts only checks for changes in affected parameter keys while ignoring variant ID changes. Additionally, it is recommended to refactor the duplicated comparison logic for experiments and rollouts into a shared helper method.
athiramanu
force-pushed
the
exp-realtime
branch
6 times, most recently
from
fce6f2a to
573ddc3
Compare
athiramanu
changed the title
athiramanu
force-pushed
the
exp-realtime
branch
7 times, most recently
from
5f6fe15 to
03fc5b9
Compare
…ion in RealtimeHandler
hsubox76
left a comment
hsubox76
left a comment
There was a problem hiding this comment.
Needs a changeset - especially in case it doesn't make it into this week's release.
4 participants
When an experiment is added whose variant value matches default value, the parameter key is not listed as updated. This becomes a problem when the client app calls activate only on config change as the experiment will not get started
Before fix - https://screencast.googleplex.com/cast/NDgxNTYwNjU0NDA3MjcwNHxiOWY1MmIyNy1iMQ
After fix - https://screencast.googleplex.com/cast/NDcxODUwODQ0MDAyNzEzNnwzODc2YTRlMC01MA