Skip to content

docs(firestore): fix formatting for pipelines docs#9908

Open
dlarocque wants to merge 8 commits into
mainfrom
dl/findnearest-docs
Open

docs(firestore): fix formatting for pipelines docs#9908
dlarocque wants to merge 8 commits into
mainfrom
dl/findnearest-docs

Conversation

@dlarocque
Copy link
Copy Markdown
Contributor

  • Fixes findNearest example doc formatting, which was causing formatting to be lost for all subsequent APIs in the TOC in devsite.
  • Removes Example: and <p>Example: from before all code examples, since we use @example for this.

- Fixes `findNearest` example doc formatting, which was causing
  formatting to be lost for all subsequent APIs in the TOC in devsite.
- Removes `Example:` and `<p>Example:` from before all code examples,
  since we use `@example` for this.
@dlarocque dlarocque requested a review from MarkDuckworth April 30, 2026 14:41
@dlarocque dlarocque requested review from a team as code owners April 30, 2026 14:41
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 30, 2026

⚠️ No Changeset found

Latest commit: 7120c95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes documentation formatting for Firestore pipelines by updating API review files, devsite markdown, and source JSDoc. A critical issue was identified in pipeline.ts where the removal of "Example:" labels resulted in malformed JSDoc tags with incorrect indentation and extra asterisks. These formatting errors need to be corrected across all affected methods to ensure proper documentation generation.

Comment thread packages/firestore/src/lite-api/pipeline.ts Outdated
dlarocque and others added 2 commits April 30, 2026 10:47
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the version number comment, lgtm

Comment thread .changeset/tame-frogs-roll.md Outdated
MarkDuckworth and others added 2 commits May 1, 2026 12:40
* docs(firestore): fix ref doc issues for piplines

* Update packages/firestore/src/lite-api/pipeline.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update packages/firestore/src/lite-api/pipeline.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* docs-devsite

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Adds `typescript` code formatting to the code examples in docs, where
they're missing.
@dlarocque dlarocque changed the title docs(firestore): fix formatting for docs code snippets docs(firestore): fix formatting for pipelines docs May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants