Skip to content

Update project.json#9997

Open
christopherfreeman311-prog wants to merge 1 commit into
firebase:mainfrom
christopherfreeman311-prog:patch-1
Open

Update project.json#9997
christopherfreeman311-prog wants to merge 1 commit into
firebase:mainfrom
christopherfreeman311-prog:patch-1

Conversation

@christopherfreeman311-prog
Copy link
Copy Markdown

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • Changes that affect the public API will require internal review. Before making a
    PR that changes the public API, we would suggest first proposing your change in an
    issue so that we can discuss it together.

@christopherfreeman311-prog christopherfreeman311-prog requested a review from a team as a code owner May 24, 2026 00:02
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 24, 2026

⚠️ No Changeset found

Latest commit: 2e45655

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes significant metadata from the .opensource/project.json file, which results in an invalid JSON structure. The feedback correctly identifies the syntax errors introduced by the deletion and highlights that the removed fields are necessary for documentation and project tracking.

Comment thread .opensource/project.json
}
]
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The changes result in an invalid JSON file. The closing brace '}' is missing, and a trailing comma remains on line 2, which is not permitted in standard JSON. Furthermore, the removal of metadata fields ('type', 'platforms', 'content', 'pages', 'tabs') is a regression. These fields are essential for documentation generation and project tracking for the Firebase SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant