Update project.json#9997
Conversation
|
There was a problem hiding this comment.
Code Review
This pull request removes significant metadata from the .opensource/project.json file, which results in an invalid JSON structure. The feedback correctly identifies the syntax errors introduced by the deletion and highlights that the removed fields are necessary for documentation and project tracking.
| } | ||
| ] | ||
| } | ||
|
|
There was a problem hiding this comment.
The changes result in an invalid JSON file. The closing brace '}' is missing, and a trailing comma remains on line 2, which is not permitted in standard JSON. Furthermore, the removal of metadata fields ('type', 'platforms', 'content', 'pages', 'tabs') is a regression. These fields are essential for documentation generation and project tracking for the Firebase SDK.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
PR that changes the public API, we would suggest first proposing your change in an
issue so that we can discuss it together.