Change the default App Hosting region to us-east4#10271
Change the default App Hosting region to us-east4#10271
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the default App Hosting location from us-central1 to us-east4 and adjusts the associated unit tests. The reviewer noted that this user-facing change requires a CHANGELOG.md entry and a specific PR description format according to the repository's style guide. Additionally, it was suggested to retain us-central1 in the test mock data to ensure the selection logic is still verified against multiple regions.
| @@ -1,3 +1,3 @@ | |||
| export const DEFAULT_LOCATION = "us-central1"; | |||
| export const DEFAULT_LOCATION = "us-east4"; | |||
There was a problem hiding this comment.
This change modifies the default location for App Hosting, which is a user-facing change. Please ensure you have updated CHANGELOG.md as required by the repository style guide (Rule 58). Additionally, the pull request description should follow the required structure (including ### Description, ### Scenarios Tested, and ### Sample Commands) as specified in Rule 53.
| describe("promptLocation", () => { | ||
| const supportedLocations = [ | ||
| { name: "us-central1", locationId: "us-central1" }, | ||
| { name: "us-east4", locationId: "us-east4" }, |
There was a problem hiding this comment.
Consider retaining us-central1 in the mock data while adding us-east4. This ensures the test continues to verify the selection logic in a more realistic scenario where multiple common regions are available.
References
- Test error cases and edge conditions, not just the 'happy path'. (link)
| default: "us-east4", | ||
| message: "Please select a location:", | ||
| choices: ["us-central1", "us-west1"], | ||
| choices: ["us-east4", "us-west1"], |
There was a problem hiding this comment.
Update the expected choices to include us-central1 to match the suggested change in the mock data.
References
- Test error cases and edge conditions, not just the 'happy path'. (link)
2 participants
Aligns with other products