[Firebase AI] Remove placeholder Firebase folder for zip frameworks#1773
[Firebase AI] Remove placeholder Firebase folder for zip frameworks#1773andrewheard wants to merge 1 commit intomainfrom
Firebase folder for zip frameworks#1773Conversation
Summary of ChangesHello @andrewheard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request partially reverts a previous change by removing redundant placeholder configurations for Firebase frameworks within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly removes the placeholder Firebase folder and its associated framework references from the Xcode project file. The changes are a partial revert, intended to allow a script to manage these dependencies, which is a good practice for project maintainability and avoiding merge conflicts. The deletions are consistent and complete across the project.pbxproj file. The change is a positive cleanup, and I have no further recommendations.
This is a partial revert of #1772. We don't need the placeholder
Firebasefolder and references because https://github.com/firebase/quickstart-ios/blob/fe0b2640e883054647f16083aa835bf6388d7071/scripts/add_framework_script.rb adds them. This resulted inerror: Unexpected duplicate tasks.The
#if canImport(FirebaseAILogic)parts of #1772 are still necessary and have not been reverted.