fix(skills): prioritize Alexandria tools and include the skill in catalogue sync - #226
ericciarla wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 3/5
skills/firecrawl-search/SKILL.md: the Alexandria discovery command is excluded by the currentallowed-toolspattern, so the skill may block or fail to authorize the newnpx firecrawl-cli@alexandria ...invocation; update the rule to explicitly cover the Alexandria command form.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="skills/firecrawl-search/SKILL.md">
<violation number="1" location="skills/firecrawl-search/SKILL.md:16">
P2: The new Alexandria discovery command is not covered by this skill's `allowed-tools` rule: `Bash(npx firecrawl-cli *)` does not match `npx firecrawl-cli@alexandria ...` because the wildcard requires a word boundary after `firecrawl-cli`. Add an explicit `Bash(npx firecrawl-cli@alexandria *)` rule to both regular skill frontmatters, or invoke Alexandria through an already-allowed command.</violation>
</file>
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
|
|
||
| ## Provider discovery before web search | ||
|
|
||
| When the Alexandria beta skill is installed and available, load `firecrawl-alexandria` first for research, comparisons, and data gathering, even when the user names no provider. Discover relevant tools with `npx firecrawl-cli@alexandria search "<required information and operation>" --sources alexandria --json`, then inspect relevant provider catalogues with `find-tools`. Use multiple complementary providers when useful and within the authorized budget. Use ordinary web search when provider tools cannot cover the request or its remaining information gaps after focused discovery. Honor explicit source/method restrictions; direct page extraction and local-file work do not require this discovery step. When Alexandria is unavailable, use the applicable workflow below. |
There was a problem hiding this comment.
P2: The new Alexandria discovery command is not covered by this skill's allowed-tools rule: Bash(npx firecrawl-cli *) does not match npx firecrawl-cli@alexandria ... because the wildcard requires a word boundary after firecrawl-cli. Add an explicit Bash(npx firecrawl-cli@alexandria *) rule to both regular skill frontmatters, or invoke Alexandria through an already-allowed command.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At skills/firecrawl-search/SKILL.md, line 16:
<comment>The new Alexandria discovery command is not covered by this skill's `allowed-tools` rule: `Bash(npx firecrawl-cli *)` does not match `npx firecrawl-cli@alexandria ...` because the wildcard requires a word boundary after `firecrawl-cli`. Add an explicit `Bash(npx firecrawl-cli@alexandria *)` rule to both regular skill frontmatters, or invoke Alexandria through an already-allowed command.</comment>
<file context>
@@ -11,6 +11,10 @@ allowed-tools:
+## Provider discovery before web search
+
+When the Alexandria beta skill is installed and available, load `firecrawl-alexandria` first for research, comparisons, and data gathering, even when the user names no provider. Discover relevant tools with `npx firecrawl-cli@alexandria search "<required information and operation>" --sources alexandria --json`, then inspect relevant provider catalogues with `find-tools`. Use multiple complementary providers when useful and within the authorized budget. Use ordinary web search when provider tools cannot cover the request or its remaining information gaps after focused discovery. Honor explicit source/method restrictions; direct page extraction and local-file work do not require this discovery step. When Alexandria is unavailable, use the applicable workflow below.
+
## Quick start
</file context>
There was a problem hiding this comment.
0 issues found across 3 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 4 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
Summary
Research requests can select ordinary web search even when Alexandria is installed. Make the skills follow this workflow:
The Alexandria skill distinguishes semantic tool search from
find-toolscatalogue filters, explains full-definition expansion and pagination, and correctsinvalid_optiondiscovery errors. It checks that capabilities support the requested operation, such as rentals versus for-sale listings. The general Firecrawl and Search skills use the same workflow when Alexandria is installed.Skill location and distribution
Move Alexandria from
beta-skills/firecrawl-alexandria/toskills/firecrawl-alexandria/and use Alexandria as its product name. Update the npm package file list,firecrawl setup alexandriasource path, and its setup test so the bundled installation keeps working.The existing
skills/**catalogue-sync workflow will now copy Alexandria intofirecrawl/skillsunderskills/core/firecrawl-alexandria/after merge. The skill remains authored in this repository; no manual edits to the catalogue mirror are needed. Existing core-install selection lists and the@alexandrianpm tag remain unchanged.Provider integrations are unchanged; existing execution budget, access, and retry rules remain in place.
Validation
pnpm run format:checkpassed.pnpm run buildpassed.npm pack --dry-run --ignore-scriptsverified that the package includesskills/firecrawl-alexandria/SKILL.mdand contains nobeta-skills/paths.git diff --checkpassed.Follow-up (outside this PR)
firecrawl-alexandriato the defaultCLI_SKILLSselection and route its setup through the standard central-catalogue installer. Keep explicit installation during testing.