Implement npm-publish workflow via shared-workflows action - #32
Implement npm-publish workflow via shared-workflows action#32devin-ai-integration[bot] wants to merge 2 commits into
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔍 PR Complexity Assessment🟡 Risk Score: 3/10
📝 SummaryMigrates NPM package publishing from JS-DevTools/npm-publish to firefliesai's shared-workflows composite action, switching from direct npmjs.org publishing to Google Artifact Registry with GitHub Packages mirroring. 📊 Lines Analysis
💡 RecommendationVerify the shared action works correctly by following the testing checklist provided. Confirm whether public npmjs.org publishing is still needed - if external consumers depend on it, this could be a breaking change. The migration pattern has been validated in other repos which reduces risk. This assessment is automated and should be used as a guide. Please use your judgment when reviewing. |
Co-Authored-By: guilherme@fireflies.ai <iamguilhermeananias@gmail.com>
| fi | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Publish Package |
|
devin, are you there? |
|
Hey! Yes, I'm here. Let me know if you have any feedback on this PR or need any changes. |
Summary
Migrate NPM package publishing from GitHub Packages (
JS-DevTools/npm-publish) to the new sharedfirefliesai/shared-workflows/.github/actions/npm-publish@maincomposite action.This publishes packages to Google Artifact Registry (GAR) with automatic GitHub Packages mirroring during the migration period, using GCP Workload Identity Federation for authentication.
Key changes:
JS-DevTools/npm-publishwithfirefliesai/shared-workflows/.github/actions/npm-publish@mainid-token: writepermission (required for GCP OIDC auth)secrets.CROSS_REPO_TOKENfor cross-repo dependency accessworkflow_dispatchtrigger for manual runssetup-node(handled by the shared action)Review & Testing Checklist for Human
npm-publish-ci-cd@fireflies-ai-ci-cd.iam.gserviceaccount.comhasroles/artifactregistry.writerfor this repo's packagespackage.jsonand push to trigger the workflowhttps://us-npm.pkg.dev/fireflies-ai/npm/)workflow_dispatchto confirm idempotency (no error on already-published version)Notes
Follows the same pattern as fred-service #922 and ai-apps-service #578.
Note: This PR removes the direct npmjs.org publishing. If public NPM publishing is still needed, it should be handled separately from the GAR migration.
Shortcut: https://app.shortcut.com/fireflies/story/110261
Link to Devin session: https://app.devin.ai/sessions/51f58ae09a0244a6879272ec220804ba