Skip to content

WIP: Migrate to esbuild #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mstange wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP: Migrate to esbuild #5589

mstange wants to merge 3 commits into from

Conversation

@mstange
Copy link
Contributor

@mstange mstange commented Sep 3, 2025 •
edited
Loading

@mstange mstange force-pushed the esbuild branch 8 times, most recently from 0455be4 to 0ec7d84 Compare September 3, 2025 23:42
@mstange mstange mentioned this pull request Nov 17, 2025
Merged
@mstange
Split gz.ts properly into node and browser variants.
4ad326f 
Use the browser variant in Jest tests.
@mstange
Move the simpleperf magic value check.
4fb7923 
esbuild only supports code splitting in the configuration where we ship
actual ES modules to the browser. In that configuration, if a module is
used by both the main chunk and an async chunk, that module becomes a
separate chunk. That's rather sillyl for a module that's just a single
constant. So we just copy the constant and remove the import.
@mstange
Use esbuild instead of webpack.
891e105
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 54.34783% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.66%. Comparing base (98b5328) to head (891e105).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/gz.ts 0.00% 12 Missing ⚠️
src/utils/window-console.ts 12.50% 7 Missing ⚠️
src/utils/gz.browser.ts 90.47% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5589      +/-   ##
==========================================
- Coverage   85.69%   85.66%   -0.03%     
==========================================
  Files         316      316              
  Lines       31141    31149       +8     
  Branches     8582     8488      -94     
==========================================
- Hits        26686    26685       -1     
- Misses       4025     4034       +9     
  Partials      430      430

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@canova canova Awaiting requested review from canova canova will be requested when the pull request is marked ready for review canova is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mstange