Skip to content

bugfix/cast_strings_as_floats#33

Open
fivetran-savage wants to merge 2 commits into
mainfrom
bugfix/cast_strings_as_floats
Open

bugfix/cast_strings_as_floats#33
fivetran-savage wants to merge 2 commits into
mainfrom
bugfix/cast_strings_as_floats

Conversation

@fivetran-savage
Copy link
Copy Markdown

@fivetran-savage fivetran-savage commented May 29, 2026

PR Overview

Package version introduced in this PR:

  • 0.9.2

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Fixes an issue in stg_workday__worker_history where annual_currency_summary_primary_compensation_basis, annual_currency_summary_total_base_pay, and annual_currency_summary_total_salary_and_allowances could surface as string datatypes by casting as float.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant