Repository navigation
app parity: host-leg row check, Rust self-skip rule, checklist 2026-10-06 revision (#1629 follow-ups) - #1647
Merged
Merged
Conversation
…XLIVE A Rust test that returns early still reports `ok`, so a leg without a host or TeX Live would pass its row. `app_parity_rows.py check` now fails a named Rust test whose body can return early unless the switch (in the test file or its `common` module) turns that skip into a failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
…er the siblings docs/evidence/app-parity-2026-10-05: A13, A14, A19, B3, C9, C20, C21, C25, D2, D5 and E4 now carry their named tests (#1627, #1628, #1630, #1632, #1633); B9 is done after #1592. Counts: 60 done, 0 partial, 1 missing (A9), 8 different. The remaining-work section lists what S5 still waits on: the owner's rulings for A6, A7, A18, C5 and C23. app-parity-rows.json follows; host_driven gains the A19 and B3 host tests (49). Plan §4.4 records the build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
…p-parity-rows-2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
…runs both Mac legs mac-v3-host (#1633) now runs `app_parity_rows.py check-log --leg host` on its swift test log, so a host-driven row test that is missing, skipped or failed fails the job. A change to the rows file or its check runs mac-app and mac-v3-host on a pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
The first `}` at column 0 after the signature can belong to the next
function when the body is a one-liner (`fn f() {}`), which made the
self-skip rule read the next test's early return as this one's.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
…p-parity-rows-2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
Contributor
Author
|
CI on head 78ea218, run 37535981831:
The first attempt of mac-v3-host (job 112516995727) failed in a test that is not a row test: |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lane P5-APP-PARITY-FINISH (kabir-claude). These are the Commander's follow-ups to #1629, now that #1627, #1628, #1630, #1632 and #1633 have landed.
Changes
mac-v3-host(ci: run the engine-v3 host tests for real (mac-v3-host); A19 and B3 host tests #1633) now runsapp_parity_rows.py check-log --leg hoston its swift test log. A host-driven row test that is missing, skipped or failed now fails that job. A change to the rows file or its check now triggersmac-appandmac-v3-hoston a pull request (theappleandv3_apppath filters).ok.checknow fails any named Rust test whose body can return early, unlessFLASHTEX_REQUIRE_TEXLIVE=1turns that skip into a failure (checked in the test file or itscommonmodule). The function body is found by brace matching.host_drivengains the A19 and B3 host tests, bringing it to 49. C21, C25, D5 and B9 are nowdone.docs/evidence/app-parity-2026-10-05revised for 2026-10-06.Verified (on the PC,
flashtex.slice)python3 -m unittest discover -s tools/parity: 255 OK, 10 skipped.app_parity_rows.py check: 69 rows, 118 named tests, all found, no Rust self-skips.check-log --leg hostagainst ci: run the engine-v3 host tests for real (mac-v3-host); A19 and B3 host tests #1633's green host log (run 37513534865, artifactmac-host-swift-test-log, 233 executed, 2 skipped benches): 49 of 49 host-driven row tests passed, not skipped.cli.rsas it was before release: ship flashtex-host in the app and flashtex-v3 + host in the CLI tarball (row D5) #1632 (d36a00f) flags all three D5 tests. Against main it is clean.retirement_refs.py: 0 problems.Where the gate stands (
app_parity_rows.py gate S5)S5 app parity: not met. The only reason left is owner retirement not in writing: A6, A7, A18, C5, C23. All 5 are "different (intended)" rows, and they need the owner's rulings (link each inowner_retirement). Every other S5 row has named tests that CI now requires to pass, not skip.S6 also waits on the A9/A17 fallbacks (M3, the bundle route) and E2, E3, E5.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp