Skip to content

app parity: host-leg row check, Rust self-skip rule, checklist 2026-10-06 revision (#1629 follow-ups) - #1647

Merged
GoKubar merged 6 commits into
mainfrom
agent/kabir-claude/app-parity-rows-2
Oct 7, 2026
Merged

GoKubar merged 6 commits into
mainfrom
agent/kabir-claude/app-parity-rows-2

Conversation

@GoKubar

@GoKubar GoKubar commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Lane P5-APP-PARITY-FINISH (kabir-claude). These are the Commander's follow-ups to #1629, now that #1627, #1628, #1630, #1632 and #1633 have landed.

Changes

  1. Host-leg row check. mac-v3-host (ci: run the engine-v3 host tests for real (mac-v3-host); A19 and B3 host tests #1633) now runs app_parity_rows.py check-log --leg host on its swift test log. A host-driven row test that is missing, skipped or failed now fails that job. A change to the rows file or its check now triggers mac-app and mac-v3-host on a pull request (the apple and v3_app path filters).
  2. Rust row tests that self-skip fail the row check. A Rust test that returns early still reports ok. check now fails any named Rust test whose body can return early, unless FLASHTEX_REQUIRE_TEXLIVE=1 turns that skip into a failure (checked in the test file or its common module). The function body is found by brace matching.
  3. Rows file regenerated after the sibling PRs. A13, A14, A19, B3, C9, C20, C21, C25, D2 and E4 now name their new tests. host_driven gains the A19 and B3 host tests, bringing it to 49. C21, C25, D5 and B9 are now done.
  4. Checklist docs/evidence/app-parity-2026-10-05 revised for 2026-10-06.
    • The rows above, plus a counts line: 60 done, 0 partial, 1 missing (A9), 8 different.
    • A rewritten remaining-work section.
    • The symlink bug B3 found (the fix is a follow-up PR).
    • Plan §4.4 records the build.

Verified (on the PC, flashtex.slice)

Where the gate stands (app_parity_rows.py gate S5)

S5 app parity: not met. The only reason left is owner retirement not in writing: A6, A7, A18, C5, C23. All 5 are "different (intended)" rows, and they need the owner's rulings (link each in owner_retirement). Every other S5 row has named tests that CI now requires to pass, not skip.

S6 also waits on the A9/A17 fallbacks (M3, the bundle route) and E2, E3, E5.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp

GoKubar and others added 6 commits October 6, 2026 15:21
…XLIVE

A Rust test that returns early still reports `ok`, so a leg without a
host or TeX Live would pass its row. `app_parity_rows.py check` now fails
a named Rust test whose body can return early unless the switch (in the
test file or its `common` module) turns that skip into a failure.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
…er the siblings

docs/evidence/app-parity-2026-10-05: A13, A14, A19, B3, C9, C20, C21, C25,
D2, D5 and E4 now carry their named tests (#1627, #1628, #1630, #1632,
#1633); B9 is done after #1592. Counts: 60 done, 0 partial, 1 missing
(A9), 8 different. The remaining-work section lists what S5 still waits
on: the owner's rulings for A6, A7, A18, C5 and C23.

app-parity-rows.json follows; host_driven gains the A19 and B3 host
tests (49). Plan §4.4 records the build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
…p-parity-rows-2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
…runs both Mac legs

mac-v3-host (#1633) now runs `app_parity_rows.py check-log --leg host`
on its swift test log, so a host-driven row test that is missing, skipped
or failed fails the job. A change to the rows file or its check runs
mac-app and mac-v3-host on a pull request.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
The first `}` at column 0 after the signature can belong to the next
function when the body is a one-liner (`fn f() {}`), which made the
self-skip rule read the next test's early return as this one's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
…p-parity-rows-2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SDAiBvi7bfkb19jLNPTtjp
@GoKubar

GoKubar commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

CI on head 78ea218, run 37535981831:

  • mac-app (job 112516995764): the hosted-leg row check passed.
  • mac-v3-host (rerun job 112542774922): app-parity-rows (host leg): 49 of 49 row tests passed, not skipped. Swift reported 242 executed, 2 skipped (the benches) and 0 failures.
  • CI required (job 112542778993): success.

The first attempt of mac-v3-host (job 112516995727) failed in a test that is not a row test: EngineV3ExportTests.testEditsDuringTheExportAreHeldThenSentAndThePreviewStaysIntact failed with "timeout waiting for the export run to start" after 91 s. It passed on the rerun, and on #1633's and #1637's runs. I read it as a timing flake on the hosted runner. That job files main-red after merge, so this test may need a longer bound.

@GoKubar
GoKubar added this pull request to the merge queue Oct 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 7, 2026
@GoKubar
GoKubar added this pull request to the merge queue Oct 7, 2026
Merged via the queue into main with commit 34e4351 Oct 7, 2026
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant