-
Notifications
You must be signed in to change notification settings - Fork 52
feat(flatpak-builder): Allow configurable build/repo/state dirs #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flatpak-builder): Allow configurable build/repo/state dirs #237
Conversation
Previously, the flatpak-builder action used hardcoded directories for the build output, local repository, and build state. This change introduces new input parameters to make these directories configurable: - 'build-dir': Specifies the directory for the application build output. - 'repo-name': Specifies the directory for the flatpak repository. - 'state-dir': Specifies the directory to store the build cache. This flexibility is crucial for environments like GitHub Actions, where default working directories might have limited space. By allowing users to specify paths, they can leverage volume mountpoints (e.g., /mnt) that offer more disk space, preventing "running out of space" errors during the build process. Signed-off-by: Zeglius <[email protected]>
|
An example of use would be: jobs:
flatpak:
name: "Flatpak"
runs-on: ubuntu-latest
container:
image: ghcr.io/flathub-infra/flatpak-github-actions:gnome-48
options: --privileged
volumes:
- /mnt/flatpak_workflow:/mnt/flatpak_workflow
steps:
- uses: actions/checkout@v4
- uses: flatpak/flatpak-github-actions/flatpak-builder@v6
with:
bundle: palette.flatpak
manifest-path: org.gnome.zbrown.Palette.yml
cache-key: flatpak-builder-${{ github.sha }}
build-dir: /mnt/flatpak_workflow/build-dir
repo-name: /mnt/flatpak_workflow/repo
state-dir: /mnt/flatpak_workflow/.flatpak-builder |
Signed-off-by: Zeglius <[email protected]>
Signed-off-by: Zeglius <[email protected]>
Signed-off-by: Zeglius <[email protected]>
Signed-off-by: Zeglius <[email protected]>
b880ab7 to
fde823c
Compare
|
When i tested your patch at bilelmoussaoui/ashpd#322 i get the same limited space error (see https://github.com/bilelmoussaoui/ashpd/actions/runs/20575989270), any clues? |
You forgot to mount a host volume, should be like this: The point of this PR was to allow using the hosts |
Previously, the flatpak-builder action used hardcoded directories for the build output, local repository, and build state. This change introduces new input parameters to make these directories configurable:
This flexibility is crucial for environments like GitHub Actions, where default working directories might have limited space. By allowing users to specify paths, they can leverage volume mountpoints (e.g., /mnt) that offer more disk space, preventing "running out of space" errors during the build process.