Release v0.2.1 - #78
Open
roncodes wants to merge 4 commits into
Open
Conversation
The inspection form and submission models handed out `createdAt` and its siblings as the raw `Date` from the attribute. A table column bound to `createdAt` therefore rendered a full datetime instance string instead of a date, which is what the inspection forms index shows today. Every other model in this package formats these getters, guarding an unparseable value with `isValidDate` first, so do the same here. The form model also carried a `frequency` attribute. Nothing schedules an inspection from it, and FleetOps has dropped it from the API resource and the console, so it is removed here too.
The inspection form and submission tests still asserted that the camelCase date getters return the raw Date, so they failed once the getters began formatting it, and the null branch of each isValidDate guard was never run, which held coverage below the 100% gate. Assert each getter through assertDateGetters, like the other models: the yyyy-MM-dd HH:mm rendering of a real date, and null for null, undefined and an unparseable Date. Also assert that the form no longer declares frequency.
Bump package.json to 0.2.1 and seed RELEASE.md so the release-tag workflow can validate the version once this branch merges to main.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2899 2913 +14
Branches 687 694 +7
=========================================
+ Hits 2899 2913 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Format the inspection models' display dates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release branch for v0.2.1. Feature PRs targeting this release are retargeted here and merge into this branch; merging this PR into
maintriggers the release-tag workflow, which tagsv0.2.1frompackage.json.Included
Release prep in this branch
package.jsonbumped0.2.0→0.2.1RELEASE.mdseeded with the v0.2.1 header and highlights (placeholders removed so the tag job passes)Update
RELEASE.mdbefore merging if the included set changes.