fix: preserve CupertinoBottomSheet content transparency - #6780
Open
ndonkoHenri wants to merge 4 commits into
Open
fix: preserve CupertinoBottomSheet content transparency#6780ndonkoHenri wants to merge 4 commits into
CupertinoBottomSheet content transparency#6780ndonkoHenri wants to merge 4 commits into
Conversation
The app template ships a `tests/` directory, but nothing placed the app's
`src/` on `sys.path`: the `flet` pytest plugin only inserts it when
`FLET_TEST_APP_PATH` is set, which nothing sets. The generated test passed
regardless, because it drives the app on-device through the `flet_app`
fixture and never imports app code — so the gap surfaced only once a module
was added next to `main.py` and given a plain unit test, which failed
collection with `ModuleNotFoundError`.
Set `pythonpath = ["src"]` in the generated `[tool.pytest.ini_options]`,
matching `[tool.flet.app].path`, so tests import app modules the same way
the app itself does — no `conftest.py`, no editable install, and no
`[build-system]` in an app that is not a distributable package.
Also drop the stale `storage/` entry from the generated `.gitignore`:
dev-mode app storage has lived in `.flet/storage/{data,cache,temp}` since
0.86, covered by the `.flet/` entry above it and by the `.gitignore` that
`flet run` writes inside `.flet/` itself.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Deploying flet-website-v2 with
|
| Latest commit: |
f74830b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d2228860.flet-website-v2.pages.dev |
| Branch Preview URL: | https://fix-cupertino-bottom-sheet-b.flet-website-v2.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Material wrapper added to fix text styling used the default canvas material type. It painted an opaque rectangular background behind custom sheet content, obscuring rounded corners and transparent padding.
Using
MaterialType.transparencyretains Material text behavior without painting that background.Fixes #4761
Summary by Sourcery
Preserve
CupertinoBottomSheetcontent transparency and improve generated Python project test imports.Bug Fixes:
CupertinoBottomSheetwhile retaining Material text styling.srcdirectory in the test import path.