Skip to content

feat(i18n): add Vietnamese translation#185

Merged
flick9000 merged 5 commits into
flick9000:feat-viLanguagefrom
vuanhvu11982-afk:main
Jun 4, 2026
Merged

feat(i18n): add Vietnamese translation#185
flick9000 merged 5 commits into
flick9000:feat-viLanguagefrom
vuanhvu11982-afk:main

Conversation

@vuanhvu11982-afk
Copy link
Copy Markdown
Contributor

Added vi.json to provide Vietnamese localization for the app interface

Added vi.json to provide Vietnamese localization for the app interface
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new Vietnamese localization file (vi.json) for the application's user interface. The review feedback points out two translation issues: '20 years' remains untranslated in English and should be localized to '20 năm', and the translation for screenshot access is grammatically incorrect and inconsistent, needing a correction to 'Tắt quyền truy cập viền chụp ảnh màn hình'.

Comment thread app/src/i18n/locales/vi.json Outdated
Comment thread app/src/i18n/locales/vi.json Outdated
vuanhvu11982-afk and others added 2 commits May 31, 2026 16:03
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Bob77781
Copy link
Copy Markdown

hello, could you please add french ?

@vuanhvu11982-afk
Copy link
Copy Markdown
Contributor Author

vuanhvu11982-afk commented May 31, 2026 via email

@vuanhvu11982-afk
Copy link
Copy Markdown
Contributor Author

Hi @Bob77781, as suggested, I have just opened a separate Pull Request (#187) specifically for the French translation (fr.json) to keep things clean. Thank you!

@Bob77781
Copy link
Copy Markdown

thank you man ! have a good day

@vuanhvu11982-afk
Copy link
Copy Markdown
Contributor Author

Hi there,

I noticed that the French translation has been processed, but the Vietnamese translation included in this PR (#185) seems to have been overlooked. All 3 commits here are ready and conflict-free.

Could you please check and merge the Vietnamese translation as well?

Thanks for your time and for maintaining this project!

@flick9000
Copy link
Copy Markdown
Owner

Hi @vuanhvu11982-afk,
Yesterday i had time to work only on one pull request, i might get back to this PR this evening or tomorrow.
Can you confirm that all the titles in the file don't end with a period (.), and all the description keys end with a period?

 - Removed periods from titles and labels.
 - Added periods to description keys per reviewer rules.
@vuanhvu11982-afk
Copy link
Copy Markdown
Contributor Author

I have updated the vi.json file to strictly follow your punctuation rules. All titles now omit periods, and description keys include them correctly. Please review it again. Thank you!

@flick9000 flick9000 changed the base branch from main to feat-viLanguage June 4, 2026 10:32
@flick9000 flick9000 merged commit a636a4f into flick9000:feat-viLanguage Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants