-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[packages] Migrate all iOS example apps in flutter/packages to UIScene #12182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zubii12
wants to merge
27
commits into
flutter:main
Choose a base branch
from
Zubii12:issue-188521-migrate-ios-examples-to-uiscene
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
347584e
feat(animations): migrate animations example to UIScene
Zubii12 5525e59
feat(camera): migrate camera example app to UIScene
Zubii12 8906505
feat(extension_google_sign_in_as_googleapis_auth): migrate extension_…
Zubii12 3e9ef9c
feat(file_selector): migrate file_selector example apps to UIScene
Zubii12 169fbcd
feat(go_router): migrate go_router example app to UIScene
Zubii12 e03204b
feat(google_fonts): migrate google_fonts example app to UIScene
Zubii12 79537aa
feat(google_maps_flutter): migrate google_maps_flutter example app to…
Zubii12 9c66306
feat(google_sign_in): migrate google_sign_in example app to UIScene
Zubii12 3c4329f
feat(image_picker): migrate image_picker example apps to UIScene
Zubii12 d472d28
feat(in_app_purchase): migrate in_app_purchase example app to UIScene
Zubii12 24444dd
feat(interactive_media_adds): migrate interactive_media_ads example a…
Zubii12 149879f
feat(local_auth): migrate example app to UIScene
Zubii12 22e60f3
feat(path_provider): migrate example apps to UIScene
Zubii12 05d4bdd
feat(pigeon): migrate example apps to UIScene
Zubii12 4d04ca5
feat(pointer_interceptor): migrate example apps to UIScene
Zubii12 bcf9a59
feat(quick_actions): migrate example app to UIScene
Zubii12 fa554a3
feat(rfw): migrate example apps to UIScene
Zubii12 517c269
feat(shared_preferences): migrate example apps to UIScene
Zubii12 cc273da
feat(two_dimensional_scrollables): migrate example app to UIScene
Zubii12 03720dd
feat(url_launcher): migrate example app to UIScene
Zubii12 5f60891
feat(video_player): migrate example app to UIScene
Zubii12 9d9047d
feat(webview_flutter): migrate example app to UIScene
Zubii12 e7651be
fix: add missing UIApplicationSceneManifest key to Info.plist
Zubii12 2e83518
fix: add missing Google Maps API key initialization
Zubii12 6fb1169
chore: remove redundant CHANGELOG & pubspec version bumps
Zubii12 8c0605b
chore: remove redundant CHANGELOG & pubspec version bumps
Zubii12 712b4a0
fix(pointer_interceptor): remove missed GeneratedPluginRegistrant.reg…
Zubii12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave it to the iOS team to decide whether we want to keep all of these no-op overrides; generally we wouldn't have an override that did nothing but call super.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few examples already migrated to the UIScene lifecycle, they all keep this no-op method.
Let me know if you want me to remove them.