[material_ui] Migrate M3 Badge template to use new gen_defaults#12218
Draft
QuncCccccc wants to merge 2 commits into
Draft
[material_ui] Migrate M3 Badge template to use new gen_defaults#12218QuncCccccc wants to merge 2 commits into
Badge template to use new gen_defaults#12218QuncCccccc wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the Badge component to use the gen_defaults tool for generating default values. It introduces a new BadgeTemplateM3, a generated badge_defaults_m3.g.dart file, and updates the generator script and test suite accordingly. The reviewer suggested further improving maintainability by tokenizing the currently hardcoded padding, alignment, and textStyle properties.
QuncCccccc
force-pushed
the
badge_m3_defaults_migration
branch
3 times, most recently
from
July 16, 2026 21:46
0dc804e to
8bbc763
Compare
QuncCccccc
force-pushed
the
badge_m3_defaults_migration
branch
from
July 16, 2026 23:40
8bbc763 to
1cd49ad
Compare
QuncCccccc
marked this pull request as draft
July 16, 2026 23:48
Contributor
Author
|
Not ready for review because of the text style token issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#188401
Pre-Review Checklist
[shared_preferences]///).