Skip to content

[material_ui] Migrate M3 BottomSheet template to use new gen_defaults#12223

Open
elliette wants to merge 3 commits into
flutter:m3e_migrationfrom
elliette:bottom-sheet-migration
Open

[material_ui] Migrate M3 BottomSheet template to use new gen_defaults#12223
elliette wants to merge 3 commits into
flutter:m3e_migrationfrom
elliette:bottom-sheet-migration

Conversation

@elliette

Copy link
Copy Markdown
Member

Work towards flutter/flutter#187899
Fixes flutter/flutter#188404

Pre-Review Checklist

Test exemption: Template migration PR.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[test exemption]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 16, 2026
@elliette
elliette requested a review from QuncCccccc July 16, 2026 21:55
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jul 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the Material 3 bottom sheet defaults to a generated part file using a new BottomSheetTemplateM3 template in the gen_defaults tool. The feedback suggests updating the constructor indentation in the template to match standard Dart formatting and using double literals for BoxConstraints to ensure consistency.

Comment on lines +21 to +27
$className(this.context)
: super(
elevation: ${number(TokenSheetBottom.dockedStandardContainerElevation)},
modalElevation: ${number(TokenSheetBottom.dockedModalContainerElevation)},
shape: ${shape(TokenSheetBottom.dockedContainerShape)},
constraints: const BoxConstraints(maxWidth: 640),
);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the constraints getter on line 48, and to explicitly use double literals for BoxConstraints parameters, use 640.0 instead of 640.

Additionally, updating the constructor's indentation to match the standard Dart style guide (which is what dart format produces) makes the template code cleaner and easier to maintain.

Suggested change
$className(this.context)
: super(
elevation: ${number(TokenSheetBottom.dockedStandardContainerElevation)},
modalElevation: ${number(TokenSheetBottom.dockedModalContainerElevation)},
shape: ${shape(TokenSheetBottom.dockedContainerShape)},
constraints: const BoxConstraints(maxWidth: 640),
);
$className(this.context)
: super(
elevation: ${number(TokenSheetBottom.dockedStandardContainerElevation)},
modalElevation: ${number(TokenSheetBottom.dockedModalContainerElevation)},
shape: ${shape(TokenSheetBottom.dockedContainerShape)},
constraints: const BoxConstraints(maxWidth: 640.0),
);
References
  1. Code should follow the relevant style guides and use the correct auto-formatter (dart format for Dart). Aligning the template's formatting with the formatter's output ensures consistency and readability. (link)

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants