Skip to content

[camera_android_camerax] Migrate skills validation test to new dart_skills_lint API#12226

Merged
reidbaker merged 1 commit into
flutter:mainfrom
reidbaker:feat/migrate-camerax-skills-linter-2026-07-16
Jul 17, 2026
Merged

[camera_android_camerax] Migrate skills validation test to new dart_skills_lint API#12226
reidbaker merged 1 commit into
flutter:mainfrom
reidbaker:feat/migrate-camerax-skills-linter-2026-07-16

Conversation

@reidbaker-agent

@reidbaker-agent reidbaker-agent commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

This update lets us use parameters in dart_skills_lint rules which is needed to be able to add evals that have artifacts that are ignored in git but exist locally.

Agent authored description below

Bumps the pinned dart_skills_lint dev_dependency ref to the latest main commit (05e5a45fa412ddbdd1d694eee0c71f4bbaea2617) and migrates the skills validation test off the deprecated LintTargetConfig.rules getter onto the new LintTargetConfig.ruleConfigs API surface.

This is the first candidate migration of the workspace-wide dart_skills_lint API updates.

  • Non-test code changed: None (only pubspec.yaml dev_dependencies and test/ suite).
  • Checks and Tests: Validated locally that formatting, static analysis, and all package tests pass cleanly.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@reidbaker
reidbaker marked this pull request as draft July 16, 2026 23:09
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@reidbaker
reidbaker self-requested a review July 17, 2026 14:52
@reidbaker reidbaker added CICD Run CI/CD override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jul 17, 2026
@reidbaker
reidbaker requested a review from camsim99 July 17, 2026 15:15
@reidbaker
reidbaker force-pushed the feat/migrate-camerax-skills-linter-2026-07-16 branch from 939cf68 to 7b9e3bc Compare July 17, 2026 15:32
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Jul 17, 2026
@reidbaker
reidbaker marked this pull request as ready for review July 17, 2026 15:51
@reidbaker reidbaker added the CICD Run CI/CD label Jul 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the git reference for the dart_skills_lint dependency in pubspec.yaml. Additionally, it updates the EnforceTrackedSkillsPreventPublishingRule test file to retrieve the configured severity using skillConfig.ruleConfigs['prevent-skills-sh-publishing']?.severity instead of skillConfig.rules['prevent-skills-sh-publishing']. There are no review comments, and I have no feedback to provide.

@camsim99 camsim99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@reidbaker
reidbaker merged commit b7c2d79 into flutter:main Jul 17, 2026
14 checks passed
@reidbaker
reidbaker deleted the feat/migrate-camerax-skills-linter-2026-07-16 branch July 17, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants