[camera_android_camerax] Migrate skills validation test to new dart_skills_lint API#12226
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
939cf68 to
7b9e3bc
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the git reference for the dart_skills_lint dependency in pubspec.yaml. Additionally, it updates the EnforceTrackedSkillsPreventPublishingRule test file to retrieve the configured severity using skillConfig.ruleConfigs['prevent-skills-sh-publishing']?.severity instead of skillConfig.rules['prevent-skills-sh-publishing']. There are no review comments, and I have no feedback to provide.
This update lets us use parameters in dart_skills_lint rules which is needed to be able to add evals that have artifacts that are ignored in git but exist locally.
Agent authored description below
Bumps the pinned
dart_skills_lintdev_dependency ref to the latest main commit (05e5a45fa412ddbdd1d694eee0c71f4bbaea2617) and migrates the skills validation test off the deprecatedLintTargetConfig.rulesgetter onto the newLintTargetConfig.ruleConfigsAPI surface.This is the first candidate migration of the workspace-wide
dart_skills_lintAPI updates.pubspec.yamldev_dependencies andtest/suite).