Skip to content

Conversation

@sfshaza2
Copy link
Contributor

Fixes #12856

Clarified 'frame' references in:

  • src/content/get-started/fundamentals/dart.md
  • src/content/get-started/fundamentals/widgets.md

Added 'Frame' definition to:

  • src/data/glossary.yml

@sfshaza2 sfshaza2 requested a review from a team as a code owner December 24, 2025 14:22
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sfshaza2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on improving the clarity and consistency of the term 'frame' across the documentation. It enhances user understanding by providing concrete time and frequency references in key articles and by introducing a thorough glossary definition. Additionally, a minor update to the site's promotional banner has been included.

Highlights

  • Documentation Clarity: Clarified the meaning of 'frame' in the dart.md and widgets.md documentation files by adding specific time and frequency estimates.
  • Glossary Expansion: A new, detailed entry for 'Frame' has been added to the glossary, providing a comprehensive definition, performance implications, and related links.
  • Site Banner Update: The site-wide banner has been updated to reflect that the December livestream has concluded and is now available as a recording.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request clarifies the concept of a 'frame' in the Flutter documentation by adding details about frame duration and frequency in a couple of guides and introducing a new glossary entry. The changes are helpful for developers trying to understand performance concepts. I've suggested a couple of minor wording improvements to make the new explanations even clearer and more precise. There's also an unrelated update to the site banner, which looks fine.

```

Perform any _quick_ initialization (less than a frame or two)
Perform any _quick_ initialization (less than a frame or two, roughly 16ms)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The clarification roughly 16ms is a bit ambiguous when paired with a frame or two. 16ms is the budget for a single frame at 60fps, so "a frame or two" would be roughly 16-32ms. The current wording could be interpreted as "a frame or two" is equivalent to "16ms", which is confusing.

To be more precise, I'd suggest specifying the range.

Suggested change
Perform any _quick_ initialization (less than a frame or two, roughly 16ms)
Perform any _quick_ initialization (less than a frame or two, roughly 16-32ms)

A single image in a sequence of images that makes up an animation or UI update.
long_description: |-
Flutter aims to produce 60 frames per second (fps), or 120 fps on capable devices.
This means the framework has approximately 16ms (or 8ms) to render each frame.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a great explanation! To make it even clearer for readers, you could explicitly associate the frame times with their respective frame rates.

    This means the framework has approximately 16ms (at 60 fps) or 8ms (at 120 fps) to render each frame.

@sfshaza2 sfshaza2 force-pushed the fix-frame-reference-12856 branch from aa15e75 to 08bc755 Compare December 24, 2025 14:25
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Dec 24, 2025

Visit the preview URL for this PR (updated for commit 08bc755):

https://flutter-docs-prod--pr12860-fix-frame-reference-12856-cv6agtvh.web.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Concept of frame is referenced before being defined

2 participants