-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix(docs): Add Groovy syntax tabs to Android deployment guide (fixes #12793) #12863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @sfshaza2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Android deployment guide by integrating Groovy syntax examples for key configuration steps. By adding tabbed code blocks for Material dependency, keystore properties, and signing configurations, the documentation now caters to a wider audience, including users with older Flutter projects or those who prefer Groovy, ensuring a more inclusive and user-friendly experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds Groovy examples alongside the existing Kotlin (KTS) examples for Android deployment configuration in deployment/android.md. The changes are well-structured using tabs to separate the two syntaxes. I've found one minor issue with an incorrect language specifier for a code block, which I've commented on. Otherwise, this is a great improvement for users who still use Groovy for their Gradle files.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Visit the preview URL for this PR (updated for commit dda734d): https://flutter-docs-prod--pr12863-fix-android-groovy-syntax-1-nnaa2dmu.web.app |
Resolves #12793 by adding Tabs to 'deployment/android.md' that provide Groovy syntax examples alongside the existing Kotlin (KTS) examples. This ensures users with older Flutter projects or those preferring Groovy can follow the Material dependency, Keystore, and Signing configuration steps.