Migrate project to Dart 3#262
Open
orestesgaolin wants to merge 6 commits intofluttercommunity:mainfrom
Open
Conversation
charafau
suggested changes
Jul 7, 2024
charafau
left a comment
charafau
left a comment
There was a problem hiding this comment.
Just few comments, thank you for updating the project 💙
|
|
||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:4.2.1' | ||
| classpath 'com.android.tools.build:gradle:8.0.2' |
There was a problem hiding this comment.
I think we should increase the agp plugin, I'd prefer to use the newest 8.5.0 if flutter supports it, if not the highest supported version would be great
example/android/app/build.gradle
Outdated
| @@ -62,8 +73,4 @@ flutter { | |||
| dependencies { | |||
| def multidex_version = "2.0.1" | |||
| implementation "androidx.multidex:multidex:$multidex_version" | |||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-all.zip |
There was a problem hiding this comment.
can we try with newer gradle?
8.7 should be good distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip
|
so when we can use this version? |
Author
|
Good question! I think I may have some time soon to finish this up. However, I think the ntire flutter_uploader library needs a thorough rework. I had some real troubles making it work when testing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to bring it to runnable state here's a chunky PR that brings the following changes:
iOS working on physical device with locally deployed backend:
0630.mp4
Tested on Android as well:
0630.1.mp4
Some issues still pending:
Tests passing locally
Closes #261
Closes #255
Closes #235
Closes #260
Closes #258
Closes #249