api: Refer condition type constants from fluxcd/pkg/apis#1144
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Apr 23, 2024
Merged
api: Refer condition type constants from fluxcd/pkg/apis#1144stefanprodan merged 1 commit intofluxcd:mainfrom
fluxcd/pkg/apis#1144stefanprodan merged 1 commit intofluxcd:mainfrom
Conversation
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
Please undo the changes to v1beta1 and v1beta2, these API versions are considered readonly.
Contributor
Author
|
sure |
Signed-off-by: gdasson <gaurav.dasson@gmail.com>
Contributor
Author
|
@stefanprodan : fixed as suggested. |
stefanprodan
changed the title
fluxcd/pkg/apis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With reference to this PR: fluxcd/pkg#723, I have referenced the kustomize constants from pkg now.