Some fixes, and some new stuff :)#10
Merged
flyingfisher merged 5 commits intoflyingfisher:masterfrom Mar 7, 2016
Merged
Conversation
... prepping for extensible commands stuf ... Signed-off-by: Daniel Smedegaard Buus <danielbuus@gmail.com>
Signed-off-by: Daniel Smedegaard Buus <danielbuus@gmail.com>
* fixed: keyEvent event type argument wasn't quoted * workaround/fix [REQUIRES PULL REQUEST #30 ON node-wd-sync TO WORK!]: elements returned by wd-sync'ified wd methods are incompatible with .execute[Async] due to make-sync code mangling. Signed-off-by: Daniel Smedegaard Buus <danielbuus@gmail.com>
WIP, needs work :) Signed-off-by: Daniel Smedegaard Buus <danielbuus@gmail.com>
Signed-off-by: Daniel Smedegaard Buus <danielbuus@gmail.com>
Contributor
Author
|
AFAICT, the conflict is the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I put the fixes in first, and I'm working on the custom user commands thing, so it's undocumented right now. I put an example in user-extension.js,
doTypeRedactor.Note: All the
keyEventcommands,focus, and the example custom command do NOT work with the NPM version of node-wd-sync. This is because sebv is automatically wrapping all elements returned by wd in "synchronize magic" code, which makes the elements incompatible with wd's .execute methods. I created a pull request with a work-around, but I'm not sure how active sebv is anymore — his last change was two years ago.... If he doesn't respond soon, I'll probably create an NPM of my own :)About the previous change in
... I actually can't remember what I meant by that note, but you seem to know what the deal is :D Could you fix that?
Thanks!! :)